Improve metadata error message to identify the error #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juankx-bodo You need to run CI |
juankx-bodo
force-pushed
the
jkx/Improve_metadata_error_message
branch
from
bf81cfe to
b127491
Compare
knassre-bodo
approved these changes
Sep 11, 2025
hadia206
approved these changes
Sep 23, 2025
| Extend with new PyDough reserved words if required. | ||
| """ | ||
| PYDOUGH_RESERVED: set[str] = { | ||
| "CALCULATE", |
There was a problem hiding this comment.
The other thing we should probably ban is any of the function names (see the builtin_registered_operators function for how to obtain these names).
There was a problem hiding this comment.
Done! I didn't know about builtin_registered_operators
juankx-bodo
force-pushed
the
jkx/Improve_metadata_error_message
branch
2 times, most recently
from
9565709 to
e52c486
Compare
Improve metadata error messages Improve metadata validations Check for reserved python keywords on metadata names Fix metadata for broker Check for Pydough and SQL reserved words Add validation for SQL names in TablePath & ColumnName Apply code review observations
juankx-bodo
force-pushed
the
jkx/Improve_metadata_error_message
branch
from
cea91f0 to
d96e49f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the error msg
name must be a string that is a Python identifierto:name: [no!Valid'Identifier\Name] must be a string that is a valid Python identifierAdd additional validation to names used in Pydough to prevent them from being Pydough or Python reserved words. Also, add validation for
table pathandcolumn nameto ensure they are valid SQL identifier names and not SQL reserved words.